[Bug 493236] Review Request: xmlfy - Convert text/UTF-8 based output into XML format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493236





--- Comment #6 from Jan Klepek <jan.klepek at hp.com>  2009-04-15 02:12:59 EDT ---
(In reply to comment #5)

> 2] Which "Source" are you referring to, the SRPM or the upstream source file
> xmlfy-1.4.2-src.tar.gz? If you use the upstream source the build will fail at
> the packaging - I use another top level Makefile "Makefile_src_archive" to
> build the source archives including the SRPM. When I build from the SRPM it
> works for me, perhaps it could be the path issue that you refer to in point 3.

Yes, I'm talking about upstream source. 
In upstream source which you are providing in your spec file, you have package
subfolder which prevent successfull build.
you could:
1] remove this directory and modify Makefile, to prevent rpmbuild which is
executed by make in %build section
2] create upstream source which would be modified as per 1]
3] modify Makefile to prevent rpmbuild which is executed by make in %build
section

source tarball in your src.rpm differs from tarball which could be downloaded
from Source0.
This breaks following rule:
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.

md5sum of tarball from provided src.rpm:
7da9b3ee78500687cc4f357f01e92f3b  xmlfy-1.4.2-src.tar.gz
md5sum of tarball from Source0:
e02f4dfb6bd94676d3a72e315da2a10a  xmlfy-1.4.2-src.tar.gz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.