[Bug 495875] Review Request: leonidas-kde-theme - Leonidas KDE Theme
bugzilla at redhat.com
bugzilla at redhat.com
Wed Apr 15 14:16:28 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=495875
Rex Dieter <rdieter at math.unl.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Alias| |leonidas-kde-theme
Flag|fedora-review? |fedora-review+
--- Comment #2 from Rex Dieter <rdieter at math.unl.edu> 2009-04-15 10:16:27 EDT ---
tested it out... for a first try, it looks pretty darn good.
rpmlint leonidas-kde-theme
leonidas-kde-theme.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/leonidas_wide.png
../backgrounds/leonidas/lion/wide/1920x1200/leonidas-1-noon.png
leonidas-kde-theme.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/leonidas_high.png
../backgrounds/leonidas/lion/normalish/1280x1024/leonidas-1-noon.png
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Tested against leonidas-backgrounds-common-10.93.1-1.fc11.noarch
looks like the targets are jpg's not png's, but that's something that can be
sorted out later. (nonblocking)
SHOULD:
1. Address rpmlint warnings (above)
2. near Source URL, include a comment pointing to
fedorahosted.org/leonidas-kde-theme upstream
3. License: leonidas-backgrounds-common is CC-BY-SA, but GPLV2 is also
included here, is that the other/plymouth bits? (either way, documenting which
parts are licensed which in a comment would help clarify for posterity).
Otherwise, it's really a simple noarch pkg, and conformant. APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list