[Bug 495411] Review Request: dnsjava - Java DNS implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495411


Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #9 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-04-15 21:28:48 EDT ---
(In reply to comment #8)
> > I guess it is. Putting
> >    iconv -f iso8859-1 -t utf8 Changelog > tmpfile
> >    touch -r  Changelog tmpfile
> >    mv -f tmpfile Changelog
> > into %prep solved the issue for me.
> Guess from what?? Using iso8859-15 give the same result. And any other 8-bit
> encoding may be on this place.
> "Ville Skyttä" is right family how you think?
> 

It might work, but I don't know if Ville will allow you to decode his family.

Anyway, I think what happens is: These iso8859-X encodings are very close to
each other. They only have a small number of characters that differ between
each other. Since this text doesn't contain any nontrivial characters that are
different in some of these iso8859-X encodings, all (or most) of these
encodings will work during the iconv conversion.

The package is good to go. Beware that, on the last SRPM above, the default is
set to *do* the tests. You will need to change that behavior before you commit,
otherwise koji will fail.

------------------------------------------
This package (dnsjava) is APPROVED by oget
------------------------------------------

Since you are now more experienced in packaging java stuff, would you like to
check out my java review requests? They are all quite similar to this one in
terms of packaging.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.