[Bug 495882] Review Request: perl-POE-Filter-Transparent-SMTP - A POE filter for SMTP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495882





--- Comment #3 from Chris Weyl <cweyl at alumni.drew.edu>  2009-04-16 01:06:19 EDT ---
I note that the LICENSE file is executable; please remove this bit before
importing/building.  (Note also the rpmlint warning on it.)

Other than that, looks good.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1301504

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
4e4f596fdd81d0c85f6f7359281903b4446b7f80 POE-Filter-Transparent-SMTP-0.2.tar.gz
4e4f596fdd81d0c85f6f7359281903b4446b7f80
POE-Filter-Transparent-SMTP-0.2.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-POE-Filter-Transparent-SMTP-0.2-1.fc10.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-POE-Filter-Transparent-SMTP-0.2-1.fc10.src.rpm
====> requires for perl-POE-Filter-Transparent-SMTP-0.2-1.fc10.src.rpm
perl(POE)  
perl(Test::Pod)  
perl(Test::Pod::Coverage)  

=====> perl-POE-Filter-Transparent-SMTP-0.2-1.fc10.noarch.rpm <=====
====> rpmlint
perl-POE-Filter-Transparent-SMTP.noarch: W: spurious-executable-perm
/usr/share/doc/perl-POE-Filter-Transparent-SMTP-0.2/LICENSE
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides for perl-POE-Filter-Transparent-SMTP-0.2-1.fc10.noarch.rpm
perl(POE::Filter::Transparent::SMTP) = 0.2
perl-POE-Filter-Transparent-SMTP = 0.2-1.fc10
====> requires for perl-POE-Filter-Transparent-SMTP-0.2-1.fc10.noarch.rpm
perl(:MODULE_COMPAT_5.10.0)  
perl(Carp)  
perl(Data::Dumper)  
perl(POE::Filter::Line)  
perl(strict)  
perl(warnings)  

APPROVED (provided LICENSE is made non-executable)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.