[Bug 496425] Review Request: perl-B-Hooks-OP-Check - Wrap OP check callbacks
bugzilla at redhat.com
bugzilla at redhat.com
Sun Apr 19 08:53:52 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496425
Iain Arnell <iarnell at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |iarnell at gmail.com
AssignedTo|nobody at fedoraproject.org |iarnell at gmail.com
Flag| |fedora-review+
--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2009-04-19 04:53:51 EDT ---
+ source files match upstream.
c794aef1af95ef73a51835274431ae23f5b3467f B-Hooks-OP-Check-0.15.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
GPL+ or Artistic
+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
http://koji.fedoraproject.org/koji/taskinfo?taskID=1307368
+ package installs properly.
+ rpmlint has an acceptable warning:
perl-B-Hooks-OP-Check.src: I: checking
perl-B-Hooks-OP-Check.x86_64: I: checking
perl-B-Hooks-OP-Check.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/B/Hooks/OP/Check/Install/hook_op_check.h
perl-B-Hooks-OP-Check-debuginfo.ppc: I: checking
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
+ final provides and requires are sane:
perl(B::Hooks::OP::Check) = 0.15
perl(B::Hooks::OP::Check::Install::Files)
perl-B-Hooks-OP-Check = 0.15-1.fc11
perl-B-Hooks-OP-Check(x86-64) = 0.15-1.fc11
=
perl(:MODULE_COMPAT_5.10.0)
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(VersionedDependencies) <= 3.0.3-1
libc.so.6()(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
perl >= 0:5.008001
perl(parent)
perl(strict)
perl(warnings)
rpmlib(VersionedDependencies) <= 3.0.3-1
rtld(GNU_HASH)
+ %check is present and all tests pass.
All tests successful.
Files=1, Tests=1, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.04 cusr 0.01
csys = 0.09 CPU)
Result: PASS
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list