[Bug 496429] Review Request: perl-B-Hooks-OP-Check-StashChange - Invoke callbacks when the stash code is being compiled in changes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=496429


Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |iarnell at gmail.com
               Flag|                            |fedora-review+




--- Comment #5 from Iain Arnell <iarnell at gmail.com>  2009-04-22 01:46:59 EDT ---
+ source files match upstream.  
  a56d9faf09f182af59384e56057bb1f0a79f89d4 
B-Hooks-OP-Check-StashChange-0.06.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
  GPL+ or Artistic 

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1313904

+ package installs properly.
+ rpmlint has acceptable warnings (and there's not much you can do about the
debuginfo error):
  perl-B-Hooks-OP-Check-StashChange.ppc: I: checking
  perl-B-Hooks-OP-Check-StashChange.ppc: W: devel-file-in-non-devel-package
/usr/lib/perl5/vendor_perl/5.10.0/ppc-linux-thread-multi/B/Hooks/OP/Check/StashChange/Install/hook_op_check_stashchange.h
  perl-B-Hooks-OP-Check-StashChange-debuginfo.ppc: I: checking
  perl-B-Hooks-OP-Check-StashChange-debuginfo.ppc: E: description-line-too-long
This package provides debug information for package
perl-B-Hooks-OP-Check-StashChange.
  perl-B-Hooks-OP-Check-StashChange.src: I: checking
  3 packages and 0 specfiles checked; 1 errors, 1 warnings.

+ final provides and requires are sane:
  perl(B::Hooks::OP::Check::StashChange) = 0.06
  perl(B::Hooks::OP::Check::StashChange::Install::Files)  
  perl-B-Hooks-OP-Check-StashChange = 0.06-1.fc12
  perl-B-Hooks-OP-Check-StashChange(ppc-32) = 0.06-1.fc12

=
  perl(:MODULE_COMPAT_5.10.0)  
  rpmlib(FileDigests) <= 4.6.0-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(VersionedDependencies) <= 3.0.3-1
  libc.so.6  
  libc.so.6(GLIBC_2.0)  
  libc.so.6(GLIBC_2.1.3)  
  perl(B::Hooks::OP::Check)  
  perl(parent)  
  perl(strict)  
  perl(warnings)  
  rpmlib(VersionedDependencies) <= 3.0.3-1
  rtld(GNU_HASH)  

+ %check is present and all tests pass.
  All tests successful.
  Files=2, Tests=4,  0 wallclock secs ( 0.04 usr  0.01 sys +  0.11 cusr  0.02
csys =  0.18 CPU)
  Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.