[Bug 496633] Review Request: monodevelop-debugger-gdb - GDB Debugger Addin for MonoDevelop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=496633


Toshio Ernie Kuratomi <a.badger at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.badger at gmail.com




--- Comment #1 from Toshio Ernie Kuratomi <a.badger at gmail.com>  2009-04-22 16:55:47 EDT ---
A few links to packaging guidelines:

List of important guideline points that all packages are reviewed for:
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines

Main Guidelines page:
https://fedoraproject.org/wiki/Packaging:Guidelines

Guidelines for packaging mono packages in Fedora:
https://fedoraproject.org/wiki/Packaging:Mono

Review:
Good:
* Package is named according to the naming Guidelines
* Spec file name matches the package name
* License of the software is MIT 
* Source matches the upstream tarball
* No locales
* No shared libraries
* No Prefix specified
* No duplicate files or directories
* Proper %clean section
* Package is code, not content
* No documentation, so no %doc subpackage
* Not a standalone GUI app so no .desktop

Needswork:
* Spec file readability -- In Fedora the sections are usually in a different
order.  Having them be in a standard order doesn't help the package build but
it does help other people reviewing the spec or who work on it later.  There's
many simple spec files in cvs to look at.  For instance:
  - http://cvs.fedoraproject.org/viewvc/rpms/monodoc/devel/monodoc.spec
* License tag should just be "MIT"
  -
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Valid_License_Short_Names
* The Source: line needs to have the full URL to the source
  - https://fedoraproject.org/wiki/Packaging:SourceURL
* The vendor: tag should not be present in Fedora specfiles.  It will be
automatically files in by the buildsystem.
* Autoreqprov should normally not be in Fedora spec files.  It is on by defaul.
* BuildArch: i386 does not belong in the spec file.  In Fedora we really only
use "BuildArch: noarch" which specifies that the package can be built on any
architecture and will create an architecture independent package.  If we need
to limit the arches that the package builds on, we use ExcludeArch or
ExclusiveArch
* env_options isn't a macro used in Fedora
* You should use %configure rather than ./configure unless there's a reason.
* --prefix=%_prefix is included in the %configure macro so you don't need it if
you use the %configure macro.
* In Fedora, mono libraries are installed in %{_libdir} instead of /usr/lib. 
On x86_64 systems, that expands to /usr/lib6 instead of /usr/lib.  So use this
in the %files section:
 
%{_libdir}/monodevelop/AddIns/MonoDevelop.Debugger/MonoDevelop.Debugger.Gdb.dll*
* package needs to rm -rf %{buildroot} at the beginning of %install
* All filenames are UTF-8
* No license file is included in the tarball so you should ask upstream if
they'll provide one with their next release.

Trying a build in mock now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.