[Bug 481536] Review Request: enano - Enano CMS, a php-based modular content management system

bugzilla at redhat.com bugzilla at redhat.com
Thu Apr 23 11:35:59 UTC 2009

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


David Nalley <david at gnsa.us> changed:

           What    |Removed                     |Added
               Flag|                            |needinfo?(ngompa13 at gmail.co
                   |                            |m)

--- Comment #2 from David Nalley <david at gnsa.us>  2009-04-23 07:35:57 EDT ---
Enano Review

FIX: rpmlint must be run on every package. The output should be posted in the
[ke4qqq at nalleyt61 rpmbuild]$ rpmlint SPECS/enano.spec 
SPECS/enano.spec: W: no-%build-section
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
[ke4qqq at nalleyt61 rpmbuild]$ rpmlint
enano.src: W: name-repeated-in-summary Enano
enano.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[ke4qqq at nalleyt61 rpmbuild]$ rpmlint
enano.noarch: W: name-repeated-in-summary Enano
enano.noarch: W: incoherent-version-in-changelog 1.1.6-2
['1.1.6-2.20090301hge1ce6a91469b.fc10', '1.1.6-2.20090301hge1ce6a91469b']
enano.noarch: E: htaccess-file /usr/share/enano/cache/.htaccess
enano.noarch: W: hidden-file-or-dir /usr/share/enano/.htaccess.new
enano.noarch: E: htaccess-file /usr/share/enano/themes/.htaccess
enano.noarch: E: non-executable-script
/usr/share/enano/images/smilies/convert.sh 0644
enano.noarch: E: htaccess-file /usr/share/enano/install/.htaccess
enano.noarch: E: script-without-shebang
enano.noarch: E: htaccess-file /usr/share/enano/includes/clientside/.htaccess
enano.noarch: E: htaccess-file /usr/share/enano/files/.htaccess
enano.noarch: E: htaccess-file /usr/share/enano/images/.htaccess
enano.noarch: E: htaccess-file /usr/share/enano/files/avatars/.htaccess
1 packages and 0 specfiles checked; 9 errors, 3 warnings.

So a few comments from rpmlint:
Since you a providing a conf file for /etc/httpd/ you should push all of the
.htaccess content to that and purge the .htaccess files. 
Put a comment in the build section and rpmlint will quit complaining about
The rest should be relatively obvious. 

OK: The package must be named according to the Package Naming Guidelines .
Though you may find it easier to use YYYYMMDDhg or something similar and note
the change number in a comment. 

OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines . 
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
FIX: The License field in the package spec file must match the actual license. 
 code and readme indicate this is GPLv2+ not GPLv2
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.

OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
FIX: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

Using method in spec to grab source doesn't agree with what's packaged in the
[ke4qqq at nalleyt61 tmp]$ md5sum ~/rpmbuild/SOURCES/enano-1.1.6-20090301.tar.gz 
[ke4qqq at nalleyt61 tmp]$ md5sum ./enano-1.1.6-20090301.tar.gz 
6450ad3e971d54680a07f69eb15ea7c6  ./enano-1.1.6-20090301.tar.gz

OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
NA: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. 
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
NA: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
NA: Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun. 
NA: If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package. Without this, use of Prefix: /usr is considered a
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 

Though I will note that you can likely remove a number of the listings in %file
by just claiming the entire directory. 

OK: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must have a %clean section, which contains rm -rf %{buildroot}
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
NA: Large documentation files must go in a -doc subpackage. (The definition of
large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]
OK: If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present. 
NA: Header files must be in a -devel package. 
NA: Static libraries must be in a -static package. 
NA: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability). 
NA: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
NA: In the vast majority of cases, devel packages must require the base package
using a fully versioned dependency: Requires: %{name} = %{version}-%{release} 
NA: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
NA: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation. 
NA: Packages must not own files or directories already owned by other packages.
The rule of thumb here is that the first package to be installed should own the
files or directories that other packages may rely upon. This means, for
example, that no package in Fedora should ever share ownership with any of the
files or directories owned by the filesystem or man package. If you feel that
you have a good reason to own a file or directory that another package owns,
then please present that at package review time. 
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
OK: All filenames in rpm packages must be valid UTF-8. 

I am also concerned about some of the bundled libraries in includes which are
actually separate programs, and may need to be packaged separately. For
instance the captcha stuff which is actually freecap. 

While this currently builds, I get a 403 (Forbidden) when I try and go to
http://localhost/enanocms/ after installing.

Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list