[Bug 496701] Review Request: gxmessage - GTK2 based xmessage clone
bugzilla at redhat.com
bugzilla at redhat.com
Thu Apr 23 21:10:01 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496701
Christian Krause <chkr at plauener.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #1 from Christian Krause <chkr at plauener.de> 2009-04-23 17:10:00 EDT ---
Package looks good.
There is only minor and non-critical issue: "Requires: info" is not needed -
please remove it before importing the package.
-> APPROVED
* rpmlint: OK
rpmlint SRPMS/gxmessage-2.12.1-1.fc10.src.rpm RPMS/i386/gxmessage-*
SPECS/gxmessage.spec
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
* naming: OK
* spec file name: OK
* License:
- GPLv3+ acceptable
- matches upstream
- matches source
- COPYING file packaged
* Source0: OK
- spectool -g works
- matches upstream
- md5sum: 48c0f8b2a18fa92724c1cec83a9aa46c gxmessage-2.12.1.tar.gz
* Compilation: OK
- locally in F10
- mock in F10
- koji for F10, F11, rawhide
- RPMOPTFLAGS used correctly
- no error messages during compilation
* legible & American English: OK
* BuildRequires: OK
* Requires: TODO (minor)
"Requires: info" should not be necessary
* locale handling: OK
* shared object files, static libraries, pkgconfig, header files: OK (n/a)
* package owns directories that it creates: OK
* no files listed twice: OK
* file permissions: OK
* %defattr used: OK
* %clean section: OK
* macro usage: OK
* large documentation into subpackage: OK (n/a)
* code vs. content: OK (only code)
* GUI application need %{name}.desktop file: OK (not a gui application by
itself)
* rm -rf $RPM_BUILD_ROOT in %install: OK
* filenames UTF-8: OK
* scriptlets: OK
- info & gtk-update-icon-cache used according to
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
* functional test: OK
- examples work
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list