[Bug 495420] Review Request: rapid-photo-downloader - Images downloader for external devices

bugzilla at redhat.com bugzilla at redhat.com
Sun Apr 26 13:08:29 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495420





--- Comment #3 from Fabian Affolter <fabian at bernewireless.net>  2009-04-26 09:08:28 EDT ---
Felix, thanks for your time to make this review.

(In reply to comment #2)
> license field matches the actual license: the spec says GPLv2 but the code
> seems to be GPLv2+ since no specific requirements are mentioned that it is v2
> only

The license is GPLv2+ (mentioned in the source headers)

> the spec installs icons but the icon cache is not updated. See
> https://fedoraproject.org/wiki/Packaging:ScriptletSnippets

fixed

Updated files:

Spec URL:
http://fab.fedorapeople.org/packages/SRPMS/rapid-photo-downloader.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/rapid-photo-downloader-0.0.8-3.b7.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list