[Bug 498220] Review Request: perl-Module-Used - Find modules loaded by Perl code without running it

bugzilla at redhat.com bugzilla at redhat.com
Wed Apr 29 15:58:28 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498220


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-04-29 11:58:27 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1328535
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
ba3421bb8f990f1729b8e2ad7fa233dc  Module-Used-v1.2.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=22,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.28 cusr  0.04
csys =  0.35 CPU)
+ Package perl-Module-Used-1.2.0-1.fc12.noarch =>
Provides: perl(Module::Used)
Requires: /usr/bin/env perl >= 0:5.008003 perl(English) perl(Exporter)
perl(File::Next) perl(Module::Used) perl(PPI::Document) perl(Readonly)
perl(strict) perl(utf8) perl(version) perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list