[Bug 497735] Review Request: php-ezc-Cache - eZ Components Cache

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497735


Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |fedora at famillecollet.com
               Flag|                            |fedora-review+




--- Comment #3 from Remi Collet <fedora at famillecollet.com>  2009-04-29 12:44:36 EDT ---
REVIEW:

+ rpmlint is ok
php-ezc-Cache.src: I: checking
php-ezc-Cache.noarch: I: checking
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
+ package name ok
+ spec file name ok
+ package meet the PHP Guidelines (new update)
+ License ok : BSD
+ License is upstream 
+ spec in english and legible
+ license file in sources is provided
+ sources match the upstream sources
d1f3d512828f50274f62f6af82b30ad5  Cache-1.4.tgz
+ Source URL ok
+ build  on F10.x86_64
+ BuildRequires (php-pear >= 1:1.4.9-1.2, php-channel(components.ez.no)) ok
+ no locale
+ no .so
+ own all directories that it creates
+ no duplicate file
+ %defattr ok
+ %clean section
+ use macros consistently
+ contain code
+ small documentation not required to run
+ no devel
+ no pkgconfig
+ no sub-package
+ no GUI
+ don't own files or directories already owned by other packages
+ %install start with rm -rf 
+ valid UTF-8
+ build in mock (fedora-rawhide-x86_64)
+ no test suite
+ scriptlets ok
+ Final Requires ok
/usr/bin/pear  
php-common >= 5.2.1
php-pear(components.ez.no/Base) >= 1.5
+ Final Provides ok
php-pear(components.ez.no/Cache) = 1.4
php-ezc-Cache = 1.4-1.fc8


SHOULD:

As you remove empty (dummy) file, you can probably also remove empty dir in
docdir
So : rm -rf ./docdir/cache

Please add a note about the use of APC for cache storage only available if
php-pecl-apc extension installed (in %description).


--------
APPROVED
--------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.