[Bug 497192] Review Request: polkit-qt - Qt bindings for PolicyKit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497192


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #2 from Parag AN(पराग) <panemade at gmail.com>  2009-04-30 06:09:02 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1330027
+ rpmlint output for SRPM and for RPM.
polkit-qt.src: E: description-line-too-long Polkit-qt is a library that lets
developers use the PolicyKit API through a nice

polkit-qt.src: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 1)

polkit-qt.i586: E: description-line-too-long Polkit-qt is a library that lets
developers use the PolicyKit API through a nice

polkit-qt.i586: W: shared-lib-calls-exit /usr/lib/libpolkit-qt-core.so.0.9.2
exit at GLIBC_2.0

polkit-qt-examples.i586: W: non-conffile-in-etc
/etc/dbus-1/system.d/org.qt.policykit.examples.conf

==> plz fix those before cvs import.

+ source files match upstream url
14cb821f8917c13ed4154a3ab8e596be  polkit-qt-0.9.2.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ polkit-qt.pc, polkit-qt-core.pc,polkit-qt-gui.pc file present.
+ -devel subpackage present.
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package polkit-qt-0.9.2-1.fc12.i586 =>
Provides: libpolkit-qt-core.so.0 libpolkit-qt-gui.so.0
Requires: libQtCore.so.4 libQtDBus.so.4 libQtGui.so.4 libQtXml.so.4 libc.so.6
libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libdbus-1.so.3 libgcc_s.so.1
libgcc_s.so.1(GCC_3.0) libglib-2.0.so.0 libm.so.6 libpolkit-dbus.so.2
libpolkit-grant.so.2 libpolkit-qt-core.so.0 libpolkit-qt-gui.so.0
libpolkit.so.2 libpthread.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH)
+ Package polkit-qt-devel-0.9.2-1.fc12.i586 =>
  Provides: pkgconfig(polkit-qt) = 0.9.2 pkgconfig(polkit-qt-core) = 0.9.2
pkgconfig(polkit-qt-gui) = 0.9.2
Requires: /usr/bin/pkg-config libpolkit-qt-core.so.0 libpolkit-qt-gui.so.0
pkgconfig(QtCore) pkgconfig(QtGui) pkgconfig(polkit) pkgconfig(polkit-dbus)
pkgconfig(polkit-grant)
+ Package polkit-qt-examples-0.9.2-1.fc12.i586 =>
  Requires: libQtCore.so.4 libQtDBus.so.4 libQtXml.so.4 libc.so.6
libc.so.6(GLIBC_2.0) libdbus-1.so.3 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0)
libglib-2.0.so.0 libm.so.6 libpolkit-dbus.so.2 libpolkit-grant.so.2
libpolkit-qt-core.so.0 libpolkit.so.2 libpthread.so.0 libstdc++.so.6
libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH)


Suggestions:
1) I think polkit-qt-examples should
Requires: dbus
2) Should query upstream to change COPYING file with text of GPLv2+.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.