[Bug 498413] Review Request: vfrnav - Flight Planning software for flights under Visual Flight Rules (VFR)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498413





--- Comment #4 from Igor Jurišković <juriskovic.igor at gmail.com>  2009-04-30 15:46:02 EDT ---
No problem.

rpmlint says:
vfrnav.spec:32: W: non-standard-group Applications/Navigation

You should change that group too to something appropriate.

You can simplify this part:
%dir %{_datadir}/%{name}
%{_datadir}/%{name}/vfrnav.png
%{_datadir}/%{name}/bluetooth.png
%{_datadir}/%{name}/BlankMap-World_gray.svg
%{_datadir}/%{name}/dbeditor.glade
%{_datadir}/%{name}/navigate.glade
%{_datadir}/%{name}/routeedit.glade
%{_datadir}/%{name}/prefs.glade
%{_datadir}/%{name}/acftperformance.glade

Like this:
%dir %{_datadir}/%{name}
%{_datadir}/%{name}/*

- you are supplying desktop file but you are not installing it.
http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

Desktop file supplied with vfrnav is weird - I never seen that kind of file. I
would recommend you to make your own desktop file. All of this is explained at
previous link.

- You are installing icons for your desktop file but you never update icon
cache. https://fedoraproject.org/wiki/PackagingDrafts/Icon_Cache

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.