[Bug 491980] Review Request: bauble - Biodiversity collection manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491980





--- Comment #6 from Pierre-YvesChibon <pingou at pingoured.fr>  2009-04-30 16:09:42 EDT ---
Taking into account spot's comment:

Review:
+ package builds koji Build =>
http://koji.fedoraproject.org/koji/taskinfo?taskID=1279214
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
98aaaa80c146fa3bbf8117b0ea2edef7 bauble-0.8.6-1.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
! BuildRequires are proper. (see below)
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package bauble-0.8.6-2.fc11.noarch =>
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix)
<= 4.0-1
Requires: /usr/bin/env /usr/bin/python python(abi) = 2.6
+ GUI App
+ Desktop file present and installed according to the guidelines

------------------

I saw in the install.py this:
> install_requires=["SQLAlchemy>=0.4.4,<0.5b1",
For your information Fedora has :
0.4.8-1.fc10 
0.5.2-2.fc11

This is the last point before I approve this package, do you have any way to
check if it works in F11 ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.