[Bug 539387] Review Request: InsightToolkit - Medical imaging processing library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=539387





--- Comment #5 from Peter Lemenkov <lemenkov at gmail.com>  2009-12-01 09:53:09 EDT ---
Notes:

* I'm not sure about name. Perhaps 'itk' would be better name than
InsightToolkit?
* No need to re-define %{name} and %{version}. Just put correct values to
proper fields (Name: and Version:) at the top of the spec.
* Source0 url should be corrected. See Source1 for example.
* %{_libdir}/%{name}/*.cmake should be placed in devel rather than in main
package, I believe. Also, I'm not sure this is a correct place to put CMake
files in. 
* Unowned directory - %{_libdir}/%{name} . Just list it as %dir in main
package's %files section.
* Source1 should be added as %doc in devel-subpackage
* In the vast majority of cases, devel packages must require the base package
using a fully versioned dependency: Requires: %{name} = %{version}-%{release}
* Files within 'Copyrght' foler must be packages as %doc.
* Consider, also, packaging of 'Docmentation' and 'Examples' folders.

Please, comment my notes, and I'll continue.

BTW, since I sponsored you, you can store files at fedorapeople.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.