[Bug 534135] Review Request: xstream - Java XML serialization library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=534135





--- Comment #11 from Lubomir Rintel <lkundrak at v3.sk>  2009-12-02 17:11:00 EDT ---
(In reply to comment #10)
> (In reply to comment #9)
> > At least: from my point of view your review is very poor.
> 
> It's more "brief". I tried to build package locally, in mock and finally in
> koji, and it passed. Another important thing is license, and that's also ok.

Jochen, seriously, what was wrong here? Please point out any deficiencies of
the package, I have a feeling that the CVS request might be delayed for this
(other, older cvs requests have been processed), so I'd really like to have
this cleared up.

> I gave it another check. There is missing one "must" from java guidelines, and
> that is "Require: java", jpackage-utils is not enough.

Fair enough. Fixed.

> * I think, javadoc shouldn't be in %doc

Fixed.

> * drop epoch from current changelog entry

Done.

New package:

SPEC: http://v3.sk/~lkundrak/SPECS/xstream.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/xstream-1.2.2-4.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.