[Bug 543566] Review Request: tsocks - Library to allow transparent SOCKS proxying

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543566





--- Comment #3 from Jean-Francois Saucier <jfsaucier at infoglobe.ca>  2009-12-05 15:35:45 EDT ---
Spec URL: http://jfsaucier.fedorapeople.org/packages/tsocks.spec
SRPM URL:
http://jfsaucier.fedorapeople.org/packages/tsocks-1.8-0.3.beta5.fc12.src.rpm


Thanks a lot for taking your time reviewing my package. I tried to solve most
bugs, see below for transcript :

* rpmlint :
rpmlint is silent on the srpm and spec file. I fixed most of the
errors/warnings on the rpm file. Here is the remaining warnings for the rpm
file :

- tsocks.i686: W: no-soname /usr/lib/libtsocks.so.1.8
I checked to solve this one, but I'm not sure how to do it cleanly and what it
affect. Can you enlight me on this?

- tsocks.i686: W: shared-lib-calls-exit /usr/lib/libtsocks.so.1.8
exit at GLIBC_2.0
I could patch the program, but I'm not sure it's worth it.

- tsocks.i686: W: devel-file-in-non-devel-package /usr/lib/libtsocks.so
tsocks need this file and it's not a devel-file.



* I submited scratch build for f11 and f12 on i386, x86_64, ppc and ppc64 and
everything is good :
http://koji.fedoraproject.org/koji/taskinfo?taskID=1851702
http://koji.fedoraproject.org/koji/taskinfo?taskID=1851708


* I patch the Makefile to remove the need of static library linking.


* I think that I fixed my version and release string. I must have misread the
guidelines ;)


* You are right, I changed the group because tsocks is more a library with a
wrapper script than an application.


* Description, man pages, add worthy files, ldconfig and changelog all fixed!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.