[Bug 483187] Review Request: kde-plasma-weather - Plasma applet for weather forecasts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483187





--- Comment #8 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-02-01 13:20:02 EDT ---
(In reply to comment #7)
> > I've been told in many reviews that %{name} should be used extensively
> 
> Did this advice have basis in fedora's packaging guidelines?  If so, where?
> 

I'm not 100% sure that it is in the guidelines (I never found it). But I have
been told this so many times by different reviewers, that I took it as an
unwritten convention, or maybe it is so deeply hidden inside the guidelines
that nobody remembers where it is... or it is just a legend.

If it is an unwritten convention, sure, you don't have to obey it. But it would
be nice if you do.

side note: Another thing that I've been told many times to use in a very
specific unique way and that I couldn't find in the guidelines is
%defattr(-,root,root,-)

> All I'm aware of, is that macros should be used consistently, ie, avoid using
> %{name} in some places and hard-code it others.

Well, strictly speaking, since %{name} has to be used in the BuildRoot, any
other usage will cause an inconsistency.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.