[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481531


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+




--- Comment #6 from Parag AN(पराग) <panemade at gmail.com>  2009-02-02 08:13:46 EDT ---
Looks Like I missed this to review after assigning myself.

Review:
+ package builds in mock (rawhide i386).
koji build=> http://koji.fedoraproject.org/koji/taskinfo?taskID=1099011
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
d1f92a8c14584d45b12d31e5ed942d4c  Test-Dynamic-1.3.3.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
All tests successful.
Files=3, Tests=9,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.22 cusr  0.03
csys =  0.27 CPU)
+ Package perl-Test-Dynamic-1.3.3-3.fc11 ->
Provides: perl(Test::Dynamic) = 1.3.3
Requires: perl >= 0:5.008003 perl(strict) perl(utf8) perl(warnings)


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.