[Bug 477870] Review Request: eclipse-emf - Eclipse Modeling Framework (EMF) Eclipse plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477870


Andrew Overholt <overholt at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




--- Comment #17 from Andrew Overholt <overholt at redhat.com>  2009-02-03 16:38:47 EDT ---
Hi Mat,

:)  I understand now about removing the . files

- I generally like to match the qualifier of upstream as sometimes plugins have
hard-coded full major.minor.micro.qualifier numbers of their dependencies. 
Ignore my silly multilib statement :)

- as for the dropins structure, if you think you can keep the %dir and various
sub-directories/files straight in the %files sections, feel free to keep it as
it is.  I just personally find it easier to deal with single lines in each
%files section.  Since you get one zip from the build, what you have is fine.

- I think you're right about the Provides as well.  I genuinely wasn't sure.

This package is APPROVED.  Thanks very much, Mat!  This package is incredibly
popular and will enable us to get many other packages in.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.