[Bug 483857] Review Request: Eina - A classic player for a modern era

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 5 22:26:36 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483857





--- Comment #5 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-02-05 17:26:35 EDT ---
Oh, that's right. No problem then.

- Now you have two rel 3's in the changelog.

Review:

MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines .
 - Home page (1) states liblomo is under LGPL, but I can't find any mention of
LGPL in the source files or the LGP license file. Thus License: GPLv2+ is OK.

MUST: Each package must consistently use macros.
 - You use $RPM_BUILD_ROOT, thus you should also use $RPM_OPT_FLAGS instead of
%{optflags}

MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability).
 - You need Requires: pkgconfig

MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
 - Fix this, too.

rpmlint output:
[jzlehtol at politzer RPMS]$ rpmlint *
eina.x86_64: W: shared-lib-calls-exit /usr/lib64/liblomo-1.0.so.1.0.0
exit at GLIBC_2.2.5
eina.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/eina ['/usr/lib64']
eina-devel.x86_64: W: no-documentation
eina.src:103: W: macro-in-%changelog files
4 packages and 0 specfiles checked; 1 errors, 2 warnings.

- You need to patch libtool to get rid of the rpath.
http://fedoraproject.org/wiki/Packaging/Guidelines#Removing_Rpath

- You need to use %%files instead of %files in %changelog.


OK'd items omitted.


(1) http://eina.sourceforge.net/about.php

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list