[Bug 484229] Review Request: qbittorrent - A bittorrent Client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484229





--- Comment #13 from leigh scott <leigh123linux at googlemail.com>  2009-02-07 19:59:05 EDT ---
(In reply to comment #12)
> * Source0 points to a web page. The following Source0 location actually points
> to a wget/curl-downloadable tarball:
> 
> http://downloads.sf.net/qbittorrent/qbittorrent-1.3.0.tar.gz
> 
> 
> > ./configure --prefix=$RPM_BUILD_ROOT%{_prefix}
> 
> This --prefix is wrong. That's too much risk that the buildroot path finds its
> way into compiled/built files. Use --prefix=%{_prefix} only.
> 
> 
> > gmake %{?_smp_mflags}
> 
> "gmake" is a softlink to "make", why not just use "make" from package "make"
> then? ;)
> 
> 
> > %doc README INSTALL NEWS COPYING AUTHORS TODO Changelog
> 
> File "INSTALL" is irrelevant to the package users.
> 
> 
> * Run "rpmlint" on your src.rpm and built rpms and apply fixes as appropriate:
> 
> $ rpmlint qbittorrent-1.3.0-4.fc10.src.rpm 
> qbittorrent.src:27: W: configure-without-libdir-spec
> qbittorrent.src:29: W: rpm-buildroot-usage %build ./configure
> --prefix=$RPM_BUILD_ROOT%{_prefix}
> qbittorrent.src:29: W: configure-without-libdir-spec
> qbittorrent.src: E: description-line-too-long A Bittorrent client using C++ /
> rb_libtorrent and a Qt4 Graphical User Interface.
> 1 packages and 0 specfiles checked; 1 errors, 3 warnings.
> 
> * The Warning about missing --libdir usage can be ignored.
> 
> 
> * Testbuild will need Rawhide (F11 devel):
> Checking for libtorrent-rasterbar >= 0.14 ... no


This isn't possible !

> > ./configure --prefix=$RPM_BUILD_ROOT%{_prefix}
> 
> This --prefix is wrong. That's too much risk that the buildroot path finds its
> way into compiled/built files. Use --prefix=%{_prefix} only.


I have read the packaging guidelines and found nothing that expressly prohibits
this , so fixing this error isn't mandatory , is this correct ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.