[Bug 484323] Review Request: perl-KinoSearch - Search engine library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484323


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #5 from Lubomir Rintel <lkundrak at v3.sk>  2009-02-10 02:02:35 EDT ---
(In reply to comment #3)
> w.r.t. license, my take is: 
> 
> Original bits are under "GPL+ or Artistic" (perl), derived bits under the
> ASL2.0;  the Fedora list of good license indicates that ASL2.0 is compatible
> with the terms of the GPLv3, so we should redistribute the entire thing under
> GPLv3+ (since GPL+ -> GPLv3+ w/o problem).

Mostly right. Yes. I don't know why I thought ASL2.0 is incompatible with all
GPL versions. I was even looking at the compatibility matrix and did not notice
that. One small correction would be that the resulting license is "GPLv3" not
"GPLv3+", since we can't tell whether ASL is compatible with license that
doesn't even exist.

Much thanks for pointing this out Chris, I've obviously not have figured that
myself and it clarifies things a lot.

(In reply to comment #4)
> I am pretty sure that none of the code is under ASL 2.0.  The Perl code is
> derived from Lucene (which is in Java) but it is a rewrite (and not even a
> straight port like Plucene).  The ASL 2.0 in section 4 allows derivative works
> to have separate copyright as long as the conditions are met.  Including the
> ASL license and the notice in the docs is one of the conditions.

I've really looked at the code yesterday and haven't found anything copied from
lucene, so my feelings are that the ASL license is here "just in case".

So my recommendations here are either of
1.) Set the License to "GPLv3" and comment appropriately
2.) Ensure (check with upstream) there's no ASL code, remove the ASL license
file and leave License set to "GPL+ or Artistic" (recommended, but don't do
that w/o contacting upstream)

This can't block a review:

APPROVED

Please address the points 0.) and 1.) of comment #2 upon import.
(I'll check! :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.