[Bug 468189] Review Request: rear - Relax and Recovery (disaster recovery framework)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468189


Robert Scheck <redhat-bugzilla at linuxnetz.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |redhat-bugzilla at linuxnetz.d
                   |                            |e




--- Comment #23 from Robert Scheck <redhat-bugzilla at linuxnetz.de>  2009-02-12 15:25:57 EDT ---
I don't know rear, but when looking to the package, I've got a few points:

- /usr/share/rear/CHANGES, /usr/share/rear/COPYING, /usr/share/rear/README,
  you're shipping twice. Kill the files in /usr/share/rear, because one time
  using %doc is enough.
- Why is /etc/rear/templates/EFI_readme.txt marked as configuration file? Is
  it a configuration file? Either it's a readme or it is a configuration file;
  but if it's readme, it should go into %doc from my point of view.
- What's /etc/rear/templates/RESULT_*? Looks like readmes as well, yes/no?
- /usr/share/doc/rear-1.7.15/rear.8 is shipped already in %{_mandir}, so please
  not also in %doc, twice is too much.
- /usr/share/rear/doc contains stuff, which is already covered by %doc and/or
  %{_mandir}, so please do not ship the directory at the RPM package.
- Is /usr/share/rear meant to be readonly? /usr/share/rear/skel looks to me as
  it would be used read-writeable as well.
- I'm not sure, whether /var/rear is correct, what will this directory contain
  when it is in regular use?
- You maybe want to use "BuildArch" rather "BuildArchitectures", but that is
  just cosmetic.
- Do you really need binutils as during runtime? Just wondering...

I don't expect you to change all my stuff mentioned above, various has maybe
to get discussed first. Can somebody summarize how /usr/share/rear is used and
which meaning it has? No changing content during rear usage?

Maybe more will come up, that's what I discovered with the first run...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.