[Bug 455226] Review Request: php-pecl-runkit - PHP Opcode Analyser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455226





--- Comment #7 from Pavel Alexeev <pahan at hubbitus.spb.su>  2009-02-15 15:20:24 EDT ---
(In reply to comment #6)
> > How I should number its versions
> 
> 0.9-1.1.CVS20080512 seems ok.
No, duedlines say what CVS, not released versions must start from 0.

I change it to 0.9-0.1.CVS20080512 enumeration.

> I'd like to see the exact commands use to build the tarball, just above the
> %source., p.e. (export greater than checkout) :
> 
> # cvs -d :pserver:cvsread at cvs.php.net/repository export -D 2009-01-22
> pecl/runkit
> # tar cjf runkit-CVS20090122.tar.bz2 -C pecl runkit
> %Source0:  %{peclName}-CVS%{CVS}.tar.bz2
Thank you, its done.


> I have well understood than patches are for PHP ABI.
> 
> Even if this package is unmaintained, please report the bug and post your
> patch(es), it will be usefull for everyone, and probably commited (last commit
> is only 5 weeks old on runkit.c).
Ok - http://pecl.php.net/bugs/bug.php?id=15969


> I don't think restarting apache for each extension is a good idea. This should
> probably be removed (Have to search about this in the Guidelines).
I agree. This comes as legacy. Restart is removed.


> Please :
> - clean release (remove .Hu... and probably not usefull #*Hu comments)
Done in release. In comments i think it is not necessary?

> - update to a recent CVS snapshot
Done.
> - register the extension (package2.xml is included)
Done.
> - add PHP ABI check (see PHP Guidelines)
Done.
> - add upstream bug reference above %patch
Done - http://pecl.php.net/bugs/bug.php?id=15969
> - use Fedora macros %pecl_xmldir, %php_extdir, %pecl_install, ...
Done.
> - clean $Revision and $Log cvs status lines (spec is quite obfuscated)
Done.
> - clean changelog (mainly % not acceptable)
Done.

http://hubbitus.net.ru/rpm/Fedora9/php-pecl-runkit/php-pecl-runkit-0.9-0.6.CVS20090215.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.