[Bug 462297] Review Request: perl-o2sms - A perl module to send SMS messages using .ie websites

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 17 12:45:15 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462297





--- Comment #1 from Miroslav Suchy <msuchy at redhat.com>  2009-02-17 07:45:13 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
OK - Spec in American English
OK - Spec is legible.
FAIL - Sources match upstream md5sum:
  could not find upstream tar.gz on given url (404 not found)
N/A - Package needs ExcludeArch
OK - BuildRequires correct
N/A - Spec handles locales/find_lang
N/A - Package is relocatable and has a reason to be.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
OK - Package is code or permissible content.
OK - Doc subpackage needed/used.
N/A - Headers/static libs in -devel subpackage.
N/A - Spec has needed ldconfig in post and postun
N/A - .pc files in -devel subpackage/requires pkgconfig
N/A - .so files in -devel subpackage.
N/A - -devel package Requires: %{name} = %{version}-%{release}
N/A - .la files are removed.
N/A - Package is a GUI app and has a .desktop file
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
FAIL - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:
Provides: perl(WWW::SMS::IE::aftsms) = 288 perl(WWW::SMS::IE::iesms) = 333
perl(WWW::SMS::IE::meteorsms) = 288 perl(WWW::SMS::IE::o2sms) = 288
perl(WWW::SMS::IE::vodasms) = 312
Requires: /usr/bin/perl perl(Data::Dumper) perl(File::Basename)
perl(File::Temp) perl(File::stat) perl(Getopt::Long) >= 2.33 perl(POSIX)
perl(Pod::Usage) perl(Storable) perl(WWW::SMS::IE::aftsms)
perl(WWW::SMS::IE::iesms) perl(WWW::SMS::IE::meteorsms)
perl(WWW::SMS::IE::o2sms) perl(WWW::SMS::IE::vodasms) perl(constant)
perl(strict) perl(vars) perl(warnings)


SHOULD Items:
OK, tested on x86_64 - Should build in mock.
OK - Should build on all supported archs
Didn't test - Should function as described.
No scriptlets - Should have sane scriptlets.
N/A - Should have subpackages require base package with fully versioned depend.
OK - Should have dist tag
FAIL - Should package latest version
N/A - check for outstanding bugs on package. (For core merge reviews)

TODO: 
can point SOURCE0 to cpan when old relases are kept? (mandatory)
can you update to latest version? (optional)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list