[Bug 485641] Review Request: pdftk - The PDF Toolkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485641





--- Comment #5 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-02-19 16:09:49 EDT ---
Finally, we can review this package :)
Here are my notes:

* rpmlint says
   pdftk.src: W: mixed-use-of-spaces-and-tabs (spaces: line 30, tab: line 1)
   pdftk.src: W: patch-not-applied Patch0: pdftk-1.41-rpmopt.patch
   pdftk.src: W: patch-not-applied Patch1: pdftk-1.41-system-libgcj.patch
   pdftk.src: W: patch-not-applied Patch2: pdftk-1.41-gcjh.patch

   - We can get rid of those patches that are commented out. We will not need
them anymore.
   - The mixed spaces/tabs is easy to fix.

* The package needs
   BuildRequires:  java-devel >= 1:1.6.0
otherwise, it will not build with mock.

* rm -rf java_libs/gnu_local java_libs/java_local java_libs/gnu
can be replaced with just
  rm -rf java_libs

* The guidelines say: "If (and only if) the source package includes the text of
the license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc."

So I think, we should remove Source1.

* %defattr(-,root,root,-) is preferred.

* There is a convenient %{_javadir} macro. You can replace the instances of
   /usr/share/java
   %{_datadir}/java
with 
   %{_javadir}
Sorry, this one is my bad. I should have told you this properly before.

* Parallel make must be supported whenever possible. If it is not supported,
this should be noted in the SPEC file as a comment.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.