[Bug 486528] Review Request: perl-HTML-Lint - Perl HTML parser and checker

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486528


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-02-20 02:51:36 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1141721
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
60bd27c6ff0bb291a9fead0cd474b75f  HTML-Lint-2.06.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=28, Tests=190,  3 wallclock secs ( 0.13 usr  0.02 sys +  2.12 cusr  0.10
csys =  2.37 CPU)
+ Package perl-HTML-Lint-2.06-1.fc11 =>
Provides: perl(HTML::Lint) = 2.06 perl(HTML::Lint::Error)
perl(HTML::Lint::HTML4) perl(HTML::Lint::Parser) perl(Test::HTML::Lint) = 2.06
weblint = 2.06-1.fc11

Requires: /usr/bin/perl perl(Exporter) perl(Getopt::Long) perl(HTML::Entities)
perl(HTML::Lint) perl(HTML::Lint) >= 2.06 perl(HTML::Lint::Error)
perl(HTML::Lint::HTML4) perl(HTML::Parser) >= 3.20 perl(HTML::Tagset) >= 3.03
perl(Test::Builder) perl(base) perl(constant) perl(strict) perl(vars)
perl(warnings)

Suggestions:
1) Not sure whether you like to document virtual provides of weblint here
->http://fedoraproject.org/wiki/VilleSkytt%C3%A4/VirtualProvides 

2) Filter out duplicate requires
perl(HTML::Lint)  
perl(HTML::Lint) >= 2.06

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.