[Bug 457160] Review Request: Zorba - General purpose XQuery processor implemented in C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457160





--- Comment #18 from Paul F. Kunz <paulfkunz at gmail.com>  2009-02-23 12:33:49 EDT ---
(In reply to comment #17)
> The LaTeX/TeX/dvips BuildRequires in comment 13 are because of this build
> failure in koji:
> 
> -- latex command LATEX_COMPILER not found but usually required. You will
> probably get warnings and user inetraction on doxy run.
> -- makeindex command MAKEINDEX_COMPILER not found but usually required.
> -- dvips command DVIPS_CONVERTER not found but usually required.
> [...]
> -- Configuring incomplete, errors occurred!
> 
> /usr/bin/makeindex is provided by package "texlive", so if LaTeX is truely
> optional, you would need the "tex(tex)" BuildRequires I marked redundant.
> 
Ok, I put that in.
> [...]
> 
> * src.rpm size has increased by factor 3. The spec %changelog doesn't mention
> that you've replaced the source tarball with one that differs from the previous
> package by a 25M diff. 

I realized in the middle of the night that I packaged the wrong version of the
sources.   The large size difference is due to additional files releated to the
testsuite used by the upstream developers.   This is fixed now.   Sorry about
the error.



> * rpmdev-diff also reveals an added space character in the %cmake invocation
> that is not commented on. Two of the three -D options now put a space between
> -D and the variable name. No reason to believe it doesn't work, it's just
> strange. With other commands, silently added whitespace may lead to problems.

I've made the white space consistent.

New upload
SRPM: ftp://zorba-xquery.com/zorba-0.9.5-4.fc10.src.rpm
SPEC: ftp://zorba-xquery.com/zorba.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.