[Bug 487392] Review Request: crash-catcher - apps crash detecting daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487392





--- Comment #1 from Dan Horák <dan at danny.cz>  2009-02-26 03:18:21 EDT ---
formal review is here, see the notes below:

BAD source files match upstream:
OK package meets naming and versioning guidelines.
BAD specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (GPLv2+). License text included in
package.
OK latest version is being packaged.
OK* BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
BAD rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths, correct
scriptlets exists
BAD owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
Ok file permissions are appropriate.
BAD scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK* no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
BAD not a GUI app

- full URL to source archive is missing
- no need to specify License in all sub-packages, it is inherited from the main
package
- parallel make is not used (use make %{?_smp_mflags})
- when you decide to create a -devel subpackage, then you must move the
libraries from the main package to a -libs sub-package to be multilib compliant
- use %{_initddir} instead of /etc/rc.d/init.d
- no need to specify BR: glib2-devel, it is resolved automatically via
gtkmm24-devel

- rpmlint complains a bit
crash-catcher.x86_64: W: no-documentation
 => mark COPYING and README as %doc

crash-catcher.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libUtils.so
crash-catcher.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/libMiddleWare.so
 => you probably want a devel subpackage

crash-catcher.x86_64: E: executable-marked-as-config-file
/etc/rc.d/init.d/crash-catcher
crash-catcher.x86_64: W: conffile-without-noreplace-flag
/etc/rc.d/init.d/crash-catcher
 => remove %config from the initsctript

crash-catcher.x86_64: E: binary-or-shlib-defines-rpath /usr/sbin/crash-catcher
['/usr/lib64']
crash-catcher.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libMiddleWare.so.0.0.1 ['/usr/lib64']
crash-catcher-addon-ccpp.x86_64: E: binary-or-shlib-defines-rpath
/usr/libexec/hookCCpp ['/usr/lib64']
 => http://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath

crash-catcher-gui.x86_64: E: non-executable-script
/usr/share/crash-catcher/CCMainWindow.py 0644
crash-catcher-gui.x86_64: E: non-executable-script
/usr/share/crash-catcher/CCDBusBackend.py 0644
 => drop the shebang lines from the scrips, they are not intended to be run on
their own

crash-catcher-gui.x86_64: E: script-without-shebang /usr/bin/cc-gui
 => add it

crash-catcher-addon-ccpp.x86_64: W: no-documentation
crash-catcher-applet.x86_64: W: no-documentation
crash-catcher-gui.x86_64: W: no-documentation
crash-catcher-plugin-logger.x86_64: W: no-documentation
crash-catcher-plugin-mailx.x86_64: W: no-documentation
crash-catcher-plugin-sqlite3.x86_64: W: no-documentation
 => can be ignored now

crash-catcher-plugin-mailx.x86_64: E: description-line-too-long
 => fix

crash-catcher-addon-ccpp.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/crash-catcher/libCCpp.so
crash-catcher-plugin-logger.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/crash-catcher/libLogger.so
crash-catcher-plugin-mailx.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/crash-catcher/libMailx.so
crash-catcher-plugin-sqlite3.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/crash-catcher/libSQLite3.so
 => link plugins with "-avoid-version" in LDFLAGS, then it is ok to have *.so
in a non-devel package

- unowned directories:
    %{_sysconfdir}/%{name}
    %{_sysconfdir}/%{name}/plugins
    %{_libdir}/%{name}
    %{_datadir}/%{name}
  first 3 should be owned by the main package, the last one by the -gui
sub-package
- the preun scriptlet controls rarpd
- plugins are usually linked with "-avoid-version" in LDFLAGS
- desktop file is missing for the gui

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.