[Bug 487365] Review Request: eclipse-oprofile - Eclipse plugin for OProfile integration

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 26 16:09:16 UTC 2009

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


--- Comment #2 from Kent Sebastian <ksebasti at redhat.com>  2009-02-26 11:09:15 EDT ---
Updated spec and srpm uploaded (same url).

>X make sure lines are <= 80 characters
>  - please add some line continuations to fix this

for some lines this introduces errors, eg:

%define corepath

can not be split. For others (eg: very long paths) it seems to harm
readability, but other than that line continuations added where possible.

>X summary and description good
>  - please add Eclipse somewhere in the Summary.  Something like "Eclipse


>X rpmlint on <this package>.srpm gives no output


>This is fine 'cause it needs to be there for correct use of pam/consolehelper,

Indeed, they are not config files per-se, since there is no configuration to be
done by the user. Once placed there they never need to be touched.

Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list