[Bug 225776] Merge Review: gamin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225776


manuel wolfshant <wolfy at nobugconsulting.ro> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tbzatek at redhat.com
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
               Flag|                            |fedora-review?




--- Comment #1 from manuel wolfshant <wolfy at nobugconsulting.ro>  2009-01-03 22:21:12 EDT ---
I happened to stumble on gamin yesterday so I figured I could do a bit of
cleanup and finish the merge review as well.

I am submitting the new version as an attachment. I have also added Tomas to
the CC: list because PKGDB shows him as primary maintainer in devel.

Issues that might still be needed to be fixed:
- the license: in July,  Spot changed the license tag to LGPLv2. However at
least one file is GPLv2 so I think that the whole package should therefore be
considered GPLv2. I have added a comment about that (but left the tag as it
was, as most probably Spot knows better)
- I have removed the exec bit on the .py files included as doc in gamin-python
and I have also solved the rpath issue which was triggered by _gamin.so. Most
of the warnings from rpmlint are now gone, but two of them are still there:
   gamin-python.x86_64: E: non-executable-script
/usr/lib64/python2.6/site-packages/gamin.py 0644
   gamin-python.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.6/site-packages/_gamin.a
 Most probably gamin.py does not need to be executable because (if I have
correctly undestood the docs) it is meant to be imported by other scripts. OTOH
I have no idea if _gamin.a is needed and if it is, if it should be packaged in
-devel or in -python.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.