[Bug 463912] Review Request: tinyows - WFS-T and FE implementation server

bugzilla at redhat.com bugzilla at redhat.com
Sun Jan 4 12:46:00 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463912





--- Comment #4 from Balint Cristian <rezso at rdsor.ro>  2009-01-04 07:45:59 EDT ---
(In reply to comment #3)
> 1.) Why do you throw away the valgrind run results?
> 
> make %{?_smp_mflags} valgrind || true


- My behaviour is to trow it, but _allways_ look at build logs.
I am unsure if on ppc64 will fail some tests (always an issue), 
if so than I complicate my life. Olso i prepare for alpha
sparc/sparc64 and i can see some failures wich stop rpm build
process.

> 
> 2.) This can be replaced
> 
> %dir %{_datadir}/%{name}
> %{_datadir}/%{name}/*
> 
> with
> 
> %{_datadir}/%{name}
> 

- will NEXTRELEASE

> and this
> 
> pushd %{buildroot}%{_datadir}/%{name}/
>    ln -s ../../../%{_sysconfdir}/%{name}/config.xml config.xml
> popd
> 
> with
> 
> ln -s ../../../%{_sysconfdir}/%{name}/config.xml
> %{buildroot}%{_datadir}/%{name}/config.xml
>

- will NEXTRELEASE

> Sorry -- I could not resist these; just because I found nothing severe ;)
> None of these is anything that would block the review:

I must Thanks for the patient and meticulous review !

> APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list