[Bug 226075] Merge Review: libXinerama
bugzilla at redhat.com
bugzilla at redhat.com
Sat Jan 17 23:05:37 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226075
Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |ajax at redhat.com,
| |mclasen at redhat.com,
| |oget.fedora at gmail.com
AssignedTo|nobody at fedoraproject.org |oget.fedora at gmail.com
Flag| |fedora-review?
--- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com> 2009-01-17 18:05:35 EDT ---
The full review arrived!
* Summary and especially the description are bizarre. Can you update them. You
can find these on the manpage:
Xinerama - API for Xinerama extension to X11 Protocol
Xinerama is a simple library designed to interface the Xinerama Extension
for
retrieving information about physical output devices which may be combined
into a single logical X screen.
* rpmlint says
libXinerama.src:18: W: unversioned-explicit-obsoletes XFree86-libs
libXinerama.src:18: W: unversioned-explicit-obsoletes xorg-x11-libs
libXinerama.src:32: W: unversioned-explicit-obsoletes XFree86-devel
libXinerama.src:32: W: unversioned-explicit-obsoletes xorg-x11-devel
libXinerama.x86_64: E: zero-length /usr/share/doc/libXinerama-1.0.3/AUTHORS
libXinerama.x86_64: E: zero-length /usr/share/doc/libXinerama-1.0.3/README
libXinerama.x86_64: W: obsolete-not-provided XFree86-libs
libXinerama.x86_64: W: obsolete-not-provided xorg-x11-libs
libXinerama-devel.x86_64: W: obsolete-not-provided XFree86-devel
libXinerama-devel.x86_64: W: obsolete-not-provided xorg-x11-devel
The zero-length files are obviously not needed so they should be removed. The
obsoletes look very problematic. Can you fix those (or alternatively explain
them in the SPEC file as comments)?
* BR: libXau-devel is not needed. Afaict it is not used.
* BRs: libX11-devel pkgconfig and xorg-x11-proto-devel are not needed. They
will be picked up by libXext-devel.
* Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability). This applies to the devel package.
! Try to make use of the %{name} macro (e.g. files sections).
* Parallel make must be supported whenever possible. If it is not supported,
this should be noted in the SPEC file as a comment.
Added Adam and Matthias to CC since they are the last two known maintainers.
Sorry if this was not desired.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the package-review
mailing list