[Bug 480528] Review Request: botan - Crypto library written in C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480528


Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jochen at herr-schmitt.de




--- Comment #1 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-01-18 14:14:43 EDT ---
Good:
+ Basename of SPEC file matches with package name
+ Package contains proper License tag
+ License tag contains BSD as a proper OSS license
+ Package contains verbatin copy of the license text
+ Package contains most recent version of the software
+ Tar ball in source package matches with upstream
(md5sum: 827c81f42cd1c118fc9bf1891be7cde5)
+ source package could downloaded form upstream with spectool
+ consistently usage of rpm macros
+ Build use RPM_OPT_FLAGS
+ Package contains devel subpackage
+ Devel subpackage has proper Requires to main package
* Local build works fine
+ Build use _smp_mflags
+ Rpmlint quite on source package
+ Rpmlint quite on binary package
+ Rpmlint quite on debuginfo package
+ Local install works fine
+ Rpmlint is quite on installed package
+ Package contains a testsuite in the %check stanza
+ Local uninstall works fine
+ Main package contains proper ldconfig scriptlets
+ Buildroot will be cleaned on the beginning of the %clean and %install stanza
+ All files of the package are owned by the package
+ %files stanza contains no duplicated file definiton
+ There are no file conflict with other packages
+ All packaged files has proper files permissions
+ As far as I can see, system libraries for bzis2, openssl and zlib was used.
+ %doc stanza is small, so we need no separate doc subpackage
+ Build on Koji works fine

Bad:
+ The files tutorial.* and api.* should be part of the devel subpackage stanza,
because they contains explainations how to develope applications for this
library

TODO:
- Please notify upstream, that each source file should have a proper
copyright notice

You package is APPROVED, if you may move the tutorial.* and api.* doc files
into the
%doc stanza of the devel subpackage

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.