[Bug 226235] Merge Review: pax

bugzilla at redhat.com bugzilla at redhat.com
Mon Jan 19 13:42:37 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226235


Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #5 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-01-19 08:42:35 EDT ---
You are welcome Ondrej. There is one more thing that I missed last time. The
guidelines state that:
"Fedora's RPM includes a %makeinstall macro but it must NOT be used when make
install DESTDIR=%{buildroot} works." [1]

For pax, this really doesn't matter much since %makeinstall just works as
desired. But it is stated in the above guideline as a "MUST" so I had to bring
it into your attention.


Otherwise, I couldn't find any problems. Review is done on my side.

-------------------------------------------
This Merge Review (pax) is APPROVED by oget
-------------------------------------------


[1]
http://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.




More information about the package-review mailing list