[Bug 480771] Review Request: tunneler - Clone of legendary Tunneler game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480771


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?




--- Comment #3 from Lubomir Rintel <lkundrak at v3.sk>  2009-01-20 14:25:24 EDT ---
(In reply to comment #2)
> -1 from my side here.
> 
> - Does not yield the guidelines for icon cache as stated here:
>   http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache

As far as I understand, these are just "best practices", not part of
guidelines. Guidelines just read "If scriptlets are used, those scriptlets must
be sane.". When it comes to my scriptlet, it is functionally equivalent and
only difference is harmless error output in case gtk-update-icon-cache.

Given it is an aesthetic annoyance, I'll use the other version when importing
the package, but this is definitely not a reason for blocking the review.

Moreover, the first form is already used in packages, and referred to in wiki:
http://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets/iconcache

> - desktop-file-install must not use a vendor. See
> https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor

Wrong again. This is not a guideline. Actually, the guideline says the
opposite:
"If upstream uses <vendor_id>, leave it intact, otherwise use fedora
as<vendor_id>."

See:
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage

> Reviews should definitely be made more thorough and conscientious. It would be
> great if you also checked the SHOULD items.

I'd be very thankful if you refrained from being harsh to other contributors at
least until you study the packaging guidelines. Thanks!

(In reply to comment #1)
> Simple and neat package to me. Rpmlint is silent, mock build ok. Package meets
> all *MUST* items.
> 
> APPROVED.

Diky za review!

New Package CVS Request
=======================
Package Name: tunneler
Short Description: Clone of legendary Tunneler game
Owners: lkundrak
Branches: EL-5 F-10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.