[Bug 478452] Review Request: libxnm - A library for parsing the XNM format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478452


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-01-26 08:28:29 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1082732
+ rpmlint is silent for SRPM 
- rpmlint is NOT silent for RPM.
libxnm.i386: W: shared-lib-calls-exit /usr/lib/libxnm-1.0.so.0.0.0
exit at GLIBC_2.0
+ source files match upstream.
368655a553e594161f14286352165e41  libxnm-0.1.2.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ libxnm.pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ ldconfig scriptlets are used.
+ Not a GUI app.

suggestions:
1) source url should be
http://downloads.sourceforge.net/xnm/%{name}-%{version}.tar.gz
2) for -devel package make docs in %files as
%doc doxygen-doc/*
==> This will reduce one level depth of directory hierarchy.

I am approving this package with hope that you will convince upstream to avoid
usage of exit() function in library project source which made rpmlint to
complain.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.