[Bug 481667] Review Request: xmlenc - XML output library for java.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481667


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #3 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-01-27 13:58:15 EDT ---
Some notes for 0.52-3:

- After discussion on fedora-devel-list, we reached consensus
  that duplicating Name in Summary is redundant.

------------------------------------------------------------
I've used the non standard group
Development/Libraries/Java. But rpmlint doesn't show more errors.
------------------------------------------------------------
- rawhide rpmlint (rpmlint-0.85-3.fc11) still complains about
  this ($ rpmlint -I non-standard-group for details)

- For Sourceforge hosted source code, please refer to
  https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

- # Doesn't run with gcj, so better build it with icedtea/openjdk too
  In such case, please use
------------------------------------------------------------
BuildRequires: java-devel >= 1:1.6.0
Requires: java >= 1:1.6.0
------------------------------------------------------------
  Note that this (Build)Requires has Epoch (1:). On Fedora
  this is Provided only by java-1.6.0-openjdk(-devel)

- Install java .jar file under %_javadir, not %_javadir/%name-%version.
  https://fedoraproject.org/wiki/Packaging/Java#Directory_structure

------------------------------------------------------------
install -d -m 755 %{buildroot}%{_docdir}/%{name}-%{version}
cp -pR CHANGES COPYRIGHT README THANKS
%{buildroot}%{_docdir}/%{name}-%{version}/
------------------------------------------------------------
- Using %doc is simpler.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.