[Bug 482856] Review Request: perl-MooseX-POE - Moose wrapper around a POE::Session

bugzilla at redhat.com bugzilla at redhat.com
Thu Jan 29 05:02:10 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482856


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-01-29 00:02:09 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1090311
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
7878a0155d9f2c582e14696c2115867e  MooseX-POE-0.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave 
All tests successful.
Files=7, Tests=185,  3 wallclock secs ( 0.05 usr  0.01 sys +  3.09 cusr  0.19
csys =  3.34 CPU)
+ Package  perl-MooseX-POE-0.1-1.fc11 =>
Provides: perl(MooseX::POE) = 0.100 perl(MooseX::POE::Aliased)
perl(MooseX::POE::Exporter) perl(MooseX::POE::Meta::Class)
perl(MooseX::POE::Meta::Class::Trait) perl(MooseX::POE::Meta::Instance)
perl(MooseX::POE::Meta::Role) perl(MooseX::POE::Meta::Trait)
perl(MooseX::POE::Object) = 0.050 perl(MooseX::POE::Object::Deferred)
perl(MooseX::POE::Role) perl(MooseX::POE::SweetArgs) perl(ooseX::POE) = 0.01
Requires: perl(B) perl(Filter::Simple) perl(Moose) perl(Moose::Exporter)
perl(Moose::Role) perl(MooseX::POE::Exporter) perl(MooseX::POE::Meta::Class)
perl(MooseX::POE::Meta::Role) perl(MooseX::POE::Object) perl(MooseX::POE::Role)
perl(POE) perl(Scalar::Util) perl(Sub::Exporter) perl(Sub::Name)
perl(metaclass) perl(overload) perl(strict) perl(warnings)

Suggestions:-
1) you can add BR:perl-MooseX-Daemonize to enable one more test.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list