[Bug 466906] Review Request: perl-NOCpulse-SetID - Provides api for correctly changing user identity

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466906


Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de




--- Comment #6 from Ralf Corsepius <rc040203 at freenet.de>  2009-01-29 03:03:41 EDT ---
(In reply to comment #4)
> sane Requires/Provides

Not quite :(

Requires(pre): perl(Class::MethodMaker)
This is very likely wrong.


Furthermore:
- Package is noarch => OPTIMIZE doesn't make any sense

- Please add perl-sig to InitialCC like most perl-packagers do.

- "make test" is claimed to require "root". 
I recommend to add an rpm option to run this testsuite 
(rpmbuild --with tests or similar). 
Better: Make the testsuite degrade gracefully if not being run as "root".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.