[Bug 481759] Review Request: python-Apptools - Enthough Tool Suite Application Tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481759





--- Comment #3 from Rakesh Pandit <rakesh.pandit at gmail.com>  2009-01-29 04:43:23 EDT ---
Questions:
* Does it may sense to pacakge the %{python_sitelib}/integrationtest directory?
I assume it's only require for testing the built package, so we should remove
this directory from the package.

Yeo .. will remove.

Bad:
- Cant find python-setupdocs in the Fedora repository

Yeah in addition to adding as depends tag I should have mentioned in comments.

- Please remove the AppTools.egg-info directory from the sources
in the %setup stanza to make sure, that the err-info files are built
from sources

>From build log of python-setupdocs it looked like even if I don't remove this
folder setuptools takes care of recreating it. Will very even before importing
python-setupdocs and do the fix accordingly. May you also check in meantime? :)

TODO:
- Not all source files have a proper copyright note
  (Please notify the upstream maintainer to fix this issue in the next release)

Yeah I have been in constant touch with upstream and this would be fixed in
next release for sure. They have already started doing the process.

- A refview shows, that mostly all files which have a copyrith note
are licensed under the terms of the BSD license. So why there are references
agains the LGPLv2+?

Actually few images are in LGPLv2+ -- confirmed from upstream. image_
LICENSE.txt has details.

Once python-setupdocs is done and build available will update.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.