[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481732





--- Comment #9 from Lubomir Rintel <lkundrak at v3.sk>  2009-01-29 12:58:28 EDT ---
(In reply to comment #8)
> Hi,
> I made informal review at https://bugzilla.redhat.com/show_bug.cgi?id=480860#c4

I like it. I'd still like to se at least a couple more, this one was pretty
easy :)

A review of this package:

1.) Package name.

To be consistent with other existing practice applied to other stardict
dictionary packages I suggest you rename the package to "stardict-dic-cs" or
"stardict-dic-cs_CZ".

You may still want to add a Provides: for the upstream name.

2.) Package version.

%define dicdate 20081201
Version: 1.0.0
Source0:
ftp://dl.cihar.com/slovnik/stable/stardict-english-czech-%{dicdate}.tar.gz

Is 1.0.0 made up? Why not use 20081201 as version?

3.) URL tag.

URL: ftp://dl.cihar.com/slovnik/stable/stardict-english-czech-%{dicdate}.tar.gz

Purpose of the URL tag is to address the package's home page, with general
information about it -- it definitely should not be the same as Source tag.

4.) BuildArchitectures tag.

This is fairly minor, but: it is commonly spelled "BuildArch:"

5.) Setup

%setup -c -T -n %{name}-%{version}
%setup -q -n %{name}-%{version} -D -T -a 0

This could be written as:

%setup -q -c -n %{name}-%{version}

6.) No need to rename the README file

install -p -m 0644 %{name}-%{dicdate}/README LICENSE

Especially when it does not contain the license text.

7.) Your %description is not informative

Description is not meant to contain information about history of the package or
its build process, but rather contents of the package. The latter URL belongs
to the Url: tag and rest should be replaced with something like:

"Czech-English and English-Czech translation dictionaries for StarDict, a
GUI-based dictionary software."

8.) Group.

I guess Applications/Text would be a far better pick than Applications/System.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.