[Bug 508954] Review Request: volume_key - An utility for manipulating storage encryption keys and passphrases

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508954





--- Comment #5 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-07-01 13:40:12 EDT ---
Good:
+ Basename of the SPEC files matches with package name
+ Package name fullfill naming guidelines
+ Package contains several subpackages
+ Package has proper license tag
+ Could download upstream sources via spectool -g
+ Package files matches with upstream
(md5sum: 882ec96bef41962a33a24d6ee5821a29  volume_key-0.2.tar.bz2
         0910632173fb960252412bf7342b42fc  cryptsetup-1.0.7-rc1.tar.bz2)
+ License tag state GPLv2 as a valid OSS license
+ Package contains verbatin copy of the license tag
+ Copyrigh note in the source files matches with license tag
+ Consitantly usage of rpm macors
+ Package has proper BuildRoot definition
+ BuildRoot will be cleaned at the beginning of %clean and %install
+ Mock build works fine agains fedora-devel-x86_64
+ Package nonour rpmootflags
+ Rpmlint is silent for source rpm
+ Scratch build on koji works fine
+ Files has proper files permissions
+ %files stanza contains no dupblicated entries
+ All packaged files belongs to this package
+ No packaged files are own by another package
+ %doc stanza is small
+ package has proper changelog


Bad:
- Application is linked staticly agains a patched release
  of cryptsetup. This is accepted temporarly to avoid un
  official changes of the programming interfaces
- Could not find libblkid-devel as BR
- you mas include the crypsetup patch via a Patch statement
- some warnings from rpmlint on binary packages
  $ rpmlint volume_key-devel-0.2-1.x86_64.rpm 
  volume_key-devel.x86_64: W: no-documentation                     
  1 packages and 0 specfiles checked; 0 errors, 1 warnings.
  [s4504kr at zeus result]$ rpmlint python-volume_key-0.2-1.x86_64.rpm
  python-volume_key.x86_64: W: no-documentation
  1 packages and 0 specfiles checked; 0 errors, 1 warnings.
- Verbatin copy of the license will no included in the %doc stanza
- Please remove the *.la files instead of exclude it in the %files stanza

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.