[Bug 508066] Review Request: python-sybase - Python interface to Sybase

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508066


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




--- Comment #2 from Jason Tibbitts <tibbs at math.uh.edu>  2009-07-01 16:51:16 EDT ---
Not much to  this one.  Is there any part of the test suite which could be run
at build time?  At least some of the tests don't seem to require a database
server.

Why not build the documentation?  It's not exactly user-friendly to provide raw
tex source and a Makefile.

* source files match upstream.  sha256sum:                 
   a4dcac0d5ac6ae9145301fd804de238d20d5ec960e7af2a25b6df850d1f8b782  python-
   sybase-0.39.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.                                                              
* description is OK.                                                          
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   sybasect.so()(64bit)
   python-sybase = 0.39-1.fc12
   python-sybase(x86-64) = 0.39-1.fc12
  =
   libct.so.4()(64bit)
   libpython2.6.so.1.0()(64bit)
   python(abi) = 2.6

? %check is not present but there seems to be a test suite.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.