[Bug 509315] Review Request: perl-CGI-Application-Plugin-Forward - Pass control from one run mode to another in CGI::Application

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 2 09:30:06 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509315


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-07-02 05:30:05 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1449056
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
2853d3a87aa5ac2e2770404b4c558dfc4e8ea782 
CGI-Application-Plugin-Forward-1.06.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=8, Tests=50,  1 wallclock secs ( 0.04 usr  0.01 sys +  0.39 cusr  0.04
csys =  0.48 CPU)
+ Package  perl-CGI-Application-Plugin-Forward-1.06-1.fc12.noarch =>
Provides: perl(CGI::Application::Plugin::Forward) = 1.06
Requires: perl(CGI::Application) perl(Carp) perl(strict) perl(vars)
perl(warnings)
+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list