[Bug 492203] Review Request: frinika - Music Workstation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492203





--- Comment #11 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info>  2009-07-02 11:35:01 EDT ---
(In reply to comment #9)
> The SevenZip is bundled in frinika's source and frinika doesn't need the patch
> if it uses this bundled source. However we are not using the SevenZip that
> comes with frinika. Instead, we are using Fedora's SevenZip. In order to use
> Fedora's SevenZip we need to patch frinika sources. This is what the patch is
> for.
Ok, thank you for the explanation. In this case all ok with this patch it is
really Fedora-related and if comment present in spec no problem here.

Than, about symlinks and ant build script - let it be, you known more than I in
this.

> In the fetch script, I only remove the parts that are known to be nonfree. The
> rest of .so, .jar, .exe binaries is removed in %prep to make sure that we are
> not using them.
Good, I found that in spec.

> But I can't get the revision number to append to the filename this way. i.e.
> $ sh frinka-snapshot.sh latest
> ---> frinika-550.tar.bz2
> Is there another way?
1) You can obtain exported revision number in both cases at end of process (how
was you do before)
2) Really you need it? frinika-550.tar.bz2 is free name. It is not contain
version number, "svn", "rev" keywords and only you and I now known what 550
represent actually. So, in this case common name like frinika.tar.bz2 or
frinika-svn.tar.bz2 is fully enough.

> > 3) I see comment about all other sources. But what about fetch instruction to
> > Source0 (about what script with what parameter must be used)?
> 
> I believe that I have been quite verbose in terms of comments. Also the fetch
> script gives an output for usage. I don't think we need more. There is no room
> for confusion.
Please, add one of the string similar to:
# ./frinika-snapshot.sh 550
or
# ./%{name}-snapshot.sh %{svnver}

> > 4) You remove DKnode, nice. But petersalomonsen component stil here.
> 
> Upstream responded that all these sources
>    petersalomonsen
>    src/uk/ac/bath/*
> are all written by them and they are going to be maintained in frinika. We
> don't need to package them separately.
Good news.

>However:
> 
> After my email, they removed
>    DKnode
>    src/uk/ac/bath/gui/vamp/
> from their sources since they are not using them. So I packaged svn revision
> 550 with these sources removed.
> 
> Ref: https://sourceforge.net/forum/forum.php?thread_id=3319021&forum_id=447356
I'm glad hear that.


By the way, it is not even started:
Splash screen appeared, and then freezes, in console:
$ frinika 
Using language: русский
config: MULTIPLEXED_AUDIO=false
config: MAXIMIZE_WINDOW=false
config: DEFAULT_SOUNDFONT=/usr/share/soundfonts/default.sf2
config: AUDIO_DIRECTORY=/home/pasha/frinika/audio
config: DIRECT_MONITORING=false
config: BIG_ENDIAN=false
config: SOUNDFONT_DIRECTORY=/usr/share/soundfonts
config: SETUP_DONE=true
no saved property for configuration option LAST_PROJECT_FILENAME, using default
config: sampleRate=44100
config: SCRIPTS_DIRECTORY=/home/pasha/frinika/scripts
config: MOUSE_NUMBER_DRAG_INTENSITY=2.0
config: GROOVE_PATTERN_DIRECTORY=/home/pasha/frinika/groovepatterns
config: TICKS_PER_QUARTER=128
config: MIDIIN_DEVICES_LIST=
config:
TEXT_LANE_FONT=java.awt.Font[family=Dialog,name=Arial,style=plain,size=8]
config: JACK_AUTO_CONNECT=false
config: AUDIO_BUFFER_LENGTH=512
config: SEQUENCER_PRIORITY=0
Exception in thread "main" java.lang.NoClassDefFoundError:
org/mozilla/javascript/Scriptable
        at
com.frinika.project.ProjectContainer.defaultInit(ProjectContainer.java:525)
        at
com.frinika.project.ProjectContainer.<init>(ProjectContainer.java:241)
        at
com.frinika.project.ProjectContainer.<init>(ProjectContainer.java:542)
        at
com.frinika.sequencer.gui.menu.CreateProjectAction.actionPerformed(CreateProjectAction.java:50)
        at com.frinika.FrinikaMain.main(FrinikaMain.java:112)
Caused by: java.lang.ClassNotFoundException: org.mozilla.javascript.Scriptable
        at java.net.URLClassLoader$1.run(URLClassLoader.java:200)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.net.URLClassLoader.findClass(URLClassLoader.java:188)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:307)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:252)
        at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:320)
        ... 5 more

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.