[Bug 484226] Review Request: ruby-icon-artist - Supporting libraries for icon artists

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484226





--- Comment #1 from Luya Tshimbalanga <luya at fedoraproject.org>  2009-07-04 15:13:03 EDT ---

+ both binary and source package passed rpmlint test
$ rpmlint ../RPMS/noarch/ruby-icon-artist-0.1.90-1.fc11.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint ruby-icon-artist-0.1.90-1.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ The package is correctly named according to Packaging Name Guideline
ruby-icon-artist

+ spec file %{name} matches the package

- Is %find_lang needed for this kind of package? If so, it should be included
for future translation.

+ Package is licensed under LGPL2+

+ COPYING which is a license file is linked under %doc

+ SPEC file is in American English and legible

+ Source used to build package matches upstream source through md5.
f5ebfea7ab6ecd4d97b1953f6cb53e97  

+ Package succesfully built and compiled
--
$ rpmbuild --rebuild ruby-icon-artist-0.1.90-1.fc10.src.rpm 
Installing ruby-icon-artist-0.1.90-1.fc10.src.rpm
warning: user mso does not exist - using root
warning: group mso does not exist - using root
warning: user mso does not exist - using root
warning: group mso does not exist - using root
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.484N5P
+ umask 022
+ cd /home/luya/rpmbuild/BUILD
+ cd /home/luya/rpmbuild/BUILD
+ rm -rf icon-artist-0.1.90
+ /usr/bin/bzip2 -dc /home/luya/rpmbuild/SOURCES/icon-artist-0.1.90.tar.bz2
+ /bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd icon-artist-0.1.90
+ /bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.z9uWzt
+ umask 022
+ cd /home/luya/rpmbuild/BUILD
+ cd icon-artist-0.1.90
+ export 'CFLAGS=-O2 -g -march=i386 -mtune=i686'
+ CFLAGS='-O2 -g -march=i386 -mtune=i686'
+ exit 0
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.ISNvd7
+ umask 022
+ cd /home/luya/rpmbuild/BUILD
+ cd icon-artist-0.1.90
+ rm -rf /home/luya/rpmbuild/BUILDROOT/ruby-icon-artist-0.1.90-1.fc11.i386
+ DESTDIR=/home/luya/rpmbuild/BUILDROOT/ruby-icon-artist-0.1.90-1.fc11.i386
+ ./install.rb
+ /usr/lib/rpm/check-rpaths /usr/lib/rpm/check-buildroot
+ /usr/lib/rpm/brp-compress
+ /usr/lib/rpm/brp-strip
+ /usr/lib/rpm/brp-strip-static-archive
+ /usr/lib/rpm/brp-strip-comment-note
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.DHMDIL
+ umask 022
+ cd /home/luya/rpmbuild/BUILD
+ cd icon-artist-0.1.90
+ exit 0
Processing files: ruby-icon-artist-0.1.90-1.fc11.noarch
Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.DX4wjq
+ umask 022
+ cd /home/luya/rpmbuild/BUILD
+ cd icon-artist-0.1.90
+
DOCDIR=/home/luya/rpmbuild/BUILDROOT/ruby-icon-artist-0.1.90-1.fc11.i386/usr/share/doc/ruby-icon-artist-0.1.90
+ export DOCDIR
+ rm -rf
/home/luya/rpmbuild/BUILDROOT/ruby-icon-artist-0.1.90-1.fc11.i386/usr/share/doc/ruby-icon-artist-0.1.90
+ /bin/mkdir -p
/home/luya/rpmbuild/BUILDROOT/ruby-icon-artist-0.1.90-1.fc11.i386/usr/share/doc/ruby-icon-artist-0.1.90
+ cp -pr doc/AUTHORS doc/classes doc/COPYING doc/created.rid doc/CREDITS
doc/files doc/fr_class_index.html doc/fr_file_index.html
doc/fr_method_index.html doc/index.html doc/rdoc-style.css
/home/luya/rpmbuild/BUILDROOT/ruby-icon-artist-0.1.90-1.fc11.i386/usr/share/doc/ruby-icon-artist-0.1.90
+ exit 0
Provides: ruby(icon-artist) = 0.1.90
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <=
3.0.3-1
Checking for unpackaged file(s): /usr/lib/rpm/check-files
/home/luya/rpmbuild/BUILDROOT/ruby-icon-artist-0.1.90-1.fc11.i386
warning: Could not canonicalize hostname: muamba.benashima
Wrote:
/home/luya/rpmbuild/RPMS/noarch/ruby-icon-artist-0.1.90-1.fc11.noarch.rpm
Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.6ZJNKK
+ umask 022
+ cd /home/luya/rpmbuild/BUILD
+ cd icon-artist-0.1.90
+ rm -rf /home/luya/rpmbuild/BUILDROOT/ruby-icon-artist-0.1.90-1.fc11.i386
+ exit 0
Executing(--clean): /bin/sh -e /var/tmp/rpm-tmp.G4Nh9p
+ umask 022
+ cd /home/luya/rpmbuild/BUILD
+ rm -rf icon-artist-0.1.90
+ exit 0

---

+ All dependencies are listed in spec file such as ruby

Those are initial reviews. I will work further once the listed issue is
resolved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.