[Bug 496742] Review Request: elfelli - Visualisation tool for flux lines

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=496742





--- Comment #9 from Fabian Affolter <fabian at bernewireless.net>  2009-07-06 18:28:14 EDT ---
(In reply to comment #8)
> - I think it would be nice if the linking would use the optflags too, but it
> seems the current elfelli build scripts don't support it. Probably it's fine
> (unless -fPIC is in %{optflags} in which case the linking too needs -fPIC).

Upstream added the scons option "ccflags".  I will get in touch with them and
see if there is a possibility to add support for optflags in the linking too.

> - You might use a macro for the release version to avoid the duplicates in
> release, source and build root. E.g.
>  %global rel rc1
> and change all references to rc1 to %{rel}.

Upstream made the 'release candidate' release only for the package review.  But
you are right that the usage of a macros would facilitate the handling.

> - You are missing the icon cache updates, see
> https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

Thanks, I missed that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.